cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vladimir-kotikov <...@git.apache.org>
Subject [GitHub] cordova-plugin-file-transfer pull request #154: CB-9022 Resolve source URI o...
Date Thu, 18 Aug 2016 13:33:55 GMT
GitHub user vladimir-kotikov opened a pull request:

    https://github.com/apache/cordova-plugin-file-transfer/pull/154

    CB-9022 Resolve source URI on background thread in

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    Android
    
    ### What does this PR do?
    This PR fixes application crash when trying to upload file from 'Content' file system,
specified by `cdvfile://localhost/content/...` URI.
    
    ### What testing has been done on this change?
    Manual and automated testing
    
    ### Checklist
    - [x] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and submitted to
secretary@apache.org.
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.
    
    We should call `remapUri` on background thread otherwise it throws `IllegalStateException`
when trying to remap  'cdvfile://localhost/content/...' URIs via `ContentFilesystem`

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vladimir-kotikov/cordova-plugin-file-transfer CB-9022

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-file-transfer/pull/154.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #154
    
----
commit 15551921f0304c4987d50d635aa2ea24a3a2c565
Author: Vladimir Kotikov <kotikov.vladimir@gmail.com>
Date:   2016-08-18T13:30:19Z

    CB-9022 Resolve source URI on background thread in
    
    We should call remapUri on background thread otherwise it
    throws IllegalStateException when trying to remap  'cdvfile://localhost/content/...' URIs
via ContentFilesystem

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message