cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jcesarmobile <...@git.apache.org>
Subject [GitHub] cordova-plugin-contacts pull request #131: CB-11455: (ios) Add mandatory iOS...
Date Tue, 02 Aug 2016 21:50:36 GMT
GitHub user jcesarmobile opened a pull request:

    https://github.com/apache/cordova-plugin-contacts/pull/131

    CB-11455: (ios) Add mandatory iOS 10 privacy description

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    iOS
    
    ### What does this PR do?
    Adds the mandatory `NSContactsUsageDescription` key to the info.plist, allowing to pass
the value as a variable.
    Documented the usage of the variable on plugin install as iOS quirk
    
    ### What testing has been done on this change?
    Tested on iOS 10 device
    
    ### Checklist
    - [X] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and submitted to
secretary@apache.org.
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jcesarmobile/cordova-plugin-contacts CB-11455

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-contacts/pull/131.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #131
    
----
commit 0dc9d7b51a5baeac77a9dc30b2edb7cd8c628b18
Author: Julio C├ęsar <jcesarmobile@gmail.com>
Date:   2016-08-02T21:39:16Z

    Added variable to set the usage

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message