cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shazron <...@git.apache.org>
Subject [GitHub] cordova-plugin-wkwebview-engine pull request #13: CB-11074 - Ensure settings...
Date Fri, 05 Aug 2016 20:26:02 GMT
GitHub user shazron opened a pull request:

    https://github.com/apache/cordova-plugin-wkwebview-engine/pull/13

    CB-11074 - Ensure settings from config.xml are taken into consideration

    Take note of the disabled "testConfigurationWithMediaPlaybackAllowsAirPlay" unit test
which demonstrates that the allowsAirPlayForMediaPlayback is not sticky (apparent Apple bug).
    
    Also, "mediaPlaybackRequiresUserAction" configuration default differs on iOS 10 versus
earlier versions (on iOS 10 it defaults to YES, when it was NO, previously). Probably due
to: https://webkit.org/blog/6784/new-video-policies-for-ios/ 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shazron/cordova-plugin-wkwebview-engine CB-11074

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-wkwebview-engine/pull/13.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #13
    
----
commit ec4350ab9b45b4e45413e30337d7a6e9e5bd5e22
Author: Shazron Abdullah <shazron@apache.org>
Date:   2016-08-04T22:47:59Z

    CB-11074 - Ensure settings from config.xml are taken into consideration
    
    Note that there is a skipped unit test "testConfigurationWithMediaPlaybackAllowsAirPlay",
which deals with an Apple bug in setting the WKWebViewConfiguration.allowsAirPlayForMediaPlayback
value.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message