cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From alsorokin <...@git.apache.org>
Subject [GitHub] cordova-plugin-media pull request #114: CB-11380 (ios) Overloaded audioFileF...
Date Fri, 26 Aug 2016 18:46:19 GMT
GitHub user alsorokin opened a pull request:

    https://github.com/apache/cordova-plugin-media/pull/114

    CB-11380 (ios) Overloaded audioFileForResource method instead of modiā€¦

    ### Platforms affected
    ios
    
    ### What does this PR do?
    https://issues.apache.org/jira/browse/CB-11380
    Overloads the audioFileForResource method instead of modifying its signature because otherwise
it would be an API breakage.
    
    ### What testing has been done on this change?
    No testing whatsoever: I don't have an access to any iOS device till tomorrow. Creating
this PR to let CI test the changes.
    
    ### Checklist
    - [x] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and submitted to
secretary@apache.org.
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [x] Added automated test coverage as appropriate for this change.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/alsorokin/cordova-plugin-media CB-11380

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-media/pull/114.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #114
    
----
commit 9f0c2e3e6bc1d76dcb0759f2aaf9e4137e391b09
Author: Alexander Sorokin <alexander.sorokin@akvelon.com>
Date:   2016-08-26T18:41:51Z

    CB-11380 (ios) Overloaded audioFileForResource method instead of modifying its signature

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message