cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From alsorokin <...@git.apache.org>
Subject [GitHub] cordova-plugin-media pull request #113: CB-11757 (ios) Error out if trying t...
Date Fri, 26 Aug 2016 13:53:25 GMT
GitHub user alsorokin opened a pull request:

    https://github.com/apache/cordova-plugin-media/pull/113

    CB-11757 (ios) Error out if trying to stop playback while in a wrong …

    
    ### Platforms affected
    ios
    
    ### What does this PR do?
    https://issues.apache.org/jira/browse/CB-11757
    Makes ios implementation to send error callback when trying to stop the playback when
the avPlayer is not yet ready.
    
    ### What testing has been done on this change?
    Manual and automated testing on iPad 2 with iOS 8.1
    Also ran modified automated tests on Android 4.4 Emulator and on desktop Windows 10.
    
    ### Checklist
    - [x] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and submitted to
secretary@apache.org.
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [x] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/alsorokin/cordova-plugin-media CB-11757

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-media/pull/113.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #113
    
----
commit ad047a1b26228717c4226289a0c4772eb02dc677
Author: Alexander Sorokin <alexander.sorokin@akvelon.com>
Date:   2016-08-26T09:48:50Z

    CB-11757 (ios) Error out if trying to stop playback while in a wrong state

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message