cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sanjeewa894 <...@git.apache.org>
Subject [GitHub] cordova-plugin-media pull request #110: CB-11085 (Android) Fixed AudioHandle...
Date Tue, 23 Aug 2016 18:54:52 GMT
GitHub user sanjeewa894 opened a pull request:

    https://github.com/apache/cordova-plugin-media/pull/110

    CB-11085 (Android) Fixed AudioHandler logs should use system log, not println

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    Android
    
    ### What does this PR do?
    This is a fix for https://issues.apache.org/jira/browse/CB-11085.
    It fixes the println to LOG (android.util.Log use in org.apache.cordova.LOG).
    
    ### What testing has been done on this change?
    Testing was unable to do.
    
    ### Checklist
    - [ ] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and submitted to
secretary@apache.org.
    - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sanjeewa894/cordova-plugin-media master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-media/pull/110.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #110
    
----
commit 9084576e1a6853c82457e2d379fb3d2a0e3364f6
Author: sanjeewa894 <sanjeewaapp@gmail.com>
Date:   2016-08-23T17:44:29Z

    Fix error output using println to Log.e

commit fac888da1b8cf88eb1fc44ac3a0e94b6d0030dbb
Author: sanjeewa894 <sanjeewaapp@gmail.com>
Date:   2016-08-23T17:46:05Z

    Merge remote-tracking branch 'origin/master'

commit c1c01b1834e1a37158b6de247ac444a1d49fbdbf
Author: sanjeewa894 <sanjeewaapp@gmail.com>
Date:   2016-08-23T17:53:12Z

    Fix error output using println to LOG.e

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message