cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From alsorokin <>
Subject [GitHub] cordova-plugin-media pull request #109: CB-11086 (Android) Fixed a crash whe...
Date Tue, 23 Aug 2016 14:33:54 GMT
GitHub user alsorokin opened a pull request:

    CB-11086 (Android) Fixed a crash when setVolume() is called

    ### Platforms affected
    ### What does this PR do?
    This is a fix for
    It fixes the crash by checking if player is null when trying to set player's volume.
    ### What testing has been done on this change?
    Tested on Android emulator 4.4, also checked that added test spec is green on iOS and
    ### Checklist
    - [x] [ICLA]( has been signed and submitted to
    - [x] [Reported an issue]( in the JIRA
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [x] Added automated test coverage as appropriate for this change.

You can merge this pull request into a Git repository by running:

    $ git pull CB-11086

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #109
commit 6c923c9b21a5417dc343aec901935be06e087e63
Author: Alexander Sorokin <>
Date:   2016-08-23T14:18:31Z

    CB-11086 (Android) Fixed a crash when setVolume() is called on unitialized audio


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message