cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From stevengill <...@git.apache.org>
Subject [GitHub] cordova-plugin-camera pull request #197: [CB-5195][CB-4078]: correctOrientat...
Date Mon, 29 Aug 2016 18:30:28 GMT
Github user stevengill commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-camera/pull/197#discussion_r76660583
  
    --- Diff: src/android/CameraLauncher.java ---
    @@ -927,6 +859,21 @@ private void writeUncompressedImage(Uri src, Uri dest) throws FileNotFoundExcept
                 }
             }
         }
    +    /**
    +     * In the special case where the default width, height and quality are unchanged
    +     * we just write the file out to disk saving the expensive Bitmap.compress function.
    +     *
    +     * @param src
    +     * @throws FileNotFoundException
    +     * @throws IOException
    +     */
    +    private void writeUncompressedImage(Uri src, Uri dest) throws FileNotFoundException,
    --- End diff --
    
    Actually, i guess you are just overloading. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message