cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jcesarmobile <>
Subject [GitHub] cordova-plugin-camera pull request #230: CB-6708: [iOS]keep the metadata of ...
Date Wed, 24 Aug 2016 22:18:46 GMT
Github user jcesarmobile commented on a diff in the pull request:
    --- Diff: src/ios/CDVCamera.m ---
    @@ -240,13 +240,9 @@ - (void)alertView:(UIAlertView *)alertView clickedButtonAtIndex:(NSInteger)butto
     - (void)repositionPopover:(CDVInvokedUrlCommand*)command
    -    if (([[self pickerController] pickerPopoverController] != nil) && [[[self
pickerController] pickerPopoverController] isPopoverVisible]) {
    +    NSDictionary* options = [command argumentAtIndex:0 withDefault:nil];
    --- End diff --
    Thanks for the PR.
    I think you forked you repo before this changes were made and didn't sync before sending
your PR, but this code is important to fix another bug.
    Can you make sure that your fork is in sync with the latest code on this repo and then
send the PR with just the relevant code to fix the issue?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message