cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cadesalaberry <...@git.apache.org>
Subject [GitHub] cordova-windows pull request #172: CB-11176 Fix windows-splashscreen compati...
Date Tue, 23 Aug 2016 12:37:21 GMT
Github user cadesalaberry commented on a diff in the pull request:

    https://github.com/apache/cordova-windows/pull/172#discussion_r75856167
  
    --- Diff: cordova-js-src/exec.js ---
    @@ -41,6 +41,20 @@ var execProxy = require('cordova/exec/proxy');
      */
     module.exports = function (success, fail, service, action, args) {
     
    +    // Handle the case when we have an old version of splashscreen plugin to avoid the
API calls failures
    +    if (service === 'SplashScreen') {
    +        var pluginsVersions = require("cordova/plugin_list").metadata;
    +        var splashscreenVersion = pluginsVersions['cordova-plugin-splashscreen'];
    +        var MIN_SPLASHSCREEN_SUPPORTED_VER = 4;
    --- End diff --
    
    From this line, should I understand that the next 4.x.x release here https://github.com/apache/cordova-plugin-splashscreen/releases
will be fully compatible with windows ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message