cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shazron <...@git.apache.org>
Subject [GitHub] cordova-plugin-wkwebview-engine issue #15: Ionic changes to WKWebView (For C...
Date Sat, 20 Aug 2016 00:41:25 GMT
Github user shazron commented on the issue:

    https://github.com/apache/cordova-plugin-wkwebview-engine/pull/15
  
    Hi,
    Some issues I've encountered, pre-testing:
    
    1. Can you prefix the issue with CB-10109 so it can be automatically tracked by the apache
bots to https://issues.apache.org/jira/browse/CB-10109
    2. All traces of "Ionic" have to be removed, in the docs or the code -- you'll have to
rework the docs so that they are Cordova centric. All the contributors to this project (indeed
any Apache project) are treated as if they are independent of any company and their contributions
should reflect as such. Attribution is through the "Author" of the commit.
    3. jshint errors that need to be resolved:
    ```
    src/ios/xhr.js: line 55, col 8, Creating global 'for' variable. Should be 'for (var property
...'.
    src/ios/xhr.js: line 58, col 8, Creating global 'for' variable. Should be 'for (var property
...'.
    src/ios/xhr.js: line 55, col 8, 'property' is not defined.
    src/ios/xhr.js: line 56, col 20, 'property' is not defined.
    src/ios/xhr.js: line 58, col 8, 'property' is not defined.
    src/ios/xhr.js: line 59, col 9, 'property' is not defined.
    src/ios/xhr.js: line 59, col 64, 'property' is not defined.
    src/ios/xhr.js: line 60, col 16, 'property' is not defined.
    src/ios/xhr.js: line 60, col 40, 'property' is not defined.
    ```
    4. The contributor, in this case, @manucorporat, **must** file an [iCLA](https://www.apache.org/licenses/icla.txt)
since this is a non-trivial contribution. This is required. I did not find one that was filed
already.
    5. The contributor's employer, in this case @driftyco, should file a [CCLA](https://www.apache.org/licenses/cla-corporate.txt).
Note that this is **not** required, but see this [FAQ item](http://www.apache.org/legal/resolved.html#are-contributors-required-to-sign-a-ccla)
on why its a good idea (particularly for the committer).
    
    I'll proceed with reviewing the actual functionality of the code next week, unless there
are any blockers to  issues 2, 4 and 5 that I have raised.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message