cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From infil00p <...@git.apache.org>
Subject [GitHub] cordova-android pull request #323: Changes for Cordova-Android 6.0.0 - Andro...
Date Thu, 18 Aug 2016 21:52:11 GMT
Github user infil00p commented on a diff in the pull request:

    https://github.com/apache/cordova-android/pull/323#discussion_r75396391
  
    --- Diff: bin/templates/cordova/lib/plugin-build.gradle ---
    @@ -21,24 +21,15 @@
     buildscript {
         repositories {
             mavenCentral()
    +        jcenter()
         }
     
         // Switch the Android Gradle plugin version requirement depending on the
         // installed version of Gradle. This dependency is documented at
         // http://tools.android.com/tech-docs/new-build-system/version-compatibility
         // and https://issues.apache.org/jira/browse/CB-8143
    -    if (gradle.gradleVersion >= "2.2") {
    -        dependencies {
    -            classpath 'com.android.tools.build:gradle:1.0.0+'
    -        }
    -    } else if (gradle.gradleVersion >= "2.1") {
    -        dependencies {
    -            classpath 'com.android.tools.build:gradle:0.14.0+'
    -        }
    -    } else {
    -        dependencies {
    -            classpath 'com.android.tools.build:gradle:0.12.0+'
    -        }
    +    dependencies {
    +        classpath 'com.android.tools.build:gradle:1.0.0+'
    --- End diff --
    
    You're correct about the switching logic being removed and it not being required.  The
information in CB-8143 is obsolete, and we already did this in the main gradle file.  We should
be using the latest gradle tools and keeping up to date with the stable Android Studio updates,
which updates extremely often, and usually updates automatically.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message