cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tony-- <...@git.apache.org>
Subject [GitHub] cordova-android pull request #323: Changes for Cordova-Android 6.0.0 - Andro...
Date Thu, 18 Aug 2016 21:09:37 GMT
Github user tony-- commented on a diff in the pull request:

    https://github.com/apache/cordova-android/pull/323#discussion_r75389738
  
    --- Diff: bin/templates/cordova/lib/plugin-build.gradle ---
    @@ -21,24 +21,15 @@
     buildscript {
         repositories {
             mavenCentral()
    +        jcenter()
         }
     
         // Switch the Android Gradle plugin version requirement depending on the
         // installed version of Gradle. This dependency is documented at
         // http://tools.android.com/tech-docs/new-build-system/version-compatibility
         // and https://issues.apache.org/jira/browse/CB-8143
    -    if (gradle.gradleVersion >= "2.2") {
    -        dependencies {
    -            classpath 'com.android.tools.build:gradle:1.0.0+'
    -        }
    -    } else if (gradle.gradleVersion >= "2.1") {
    -        dependencies {
    -            classpath 'com.android.tools.build:gradle:0.14.0+'
    -        }
    -    } else {
    -        dependencies {
    -            classpath 'com.android.tools.build:gradle:0.12.0+'
    -        }
    +    dependencies {
    +        classpath 'com.android.tools.build:gradle:1.0.0+'
    --- End diff --
    
    I'm not very familiar with gradle compatibility issues, but it appears that this change
removes backwards compatibility.  I'm guessing anything <1.0.0 is deprecated/EOL and no
switching logic is required anymore.
    
    It seems like the preceding comment should be updated or removed since there is no more
switching logic and the information in CB-8143 is obsolete?  I don't know enough to update
the comment appropriately, sorry.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message