cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From daserge <...@git.apache.org>
Subject [GitHub] cordova-lib pull request #480: CB-11687 platform-specific plugin prepare hoo...
Date Tue, 16 Aug 2016 11:30:20 GMT
Github user daserge commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/480#discussion_r74917605
  
    --- Diff: cordova-lib/src/cordova/prepare.js ---
    @@ -37,23 +37,25 @@ function prepare(options) {
         return Q().then(function() {
             var projectRoot = cordova_util.cdProjectRoot();
             var config_json = config.read(projectRoot);
    -        options = options || { verbose: false, platforms: [], options: {} };
    +        options = options || { verbose: false, options: {} };
    +        options.platforms = options.platforms || cordova_util.listPlatforms(projectRoot);
    --- End diff --
    
    No, because preProcessOptions will throw `No platforms added to this project` on restoring
([save.spec](https://github.com/apache/cordova-lib/blob/2a178662acfad9c779114fddd815e484fc1b6f1d/cordova-lib/spec-cordova/save.spec.js#L613)).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message