cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shazron <...@git.apache.org>
Subject [GitHub] cordova-ios issue #234: CB-9825 cocoapod integration for plugins
Date Fri, 12 Aug 2016 00:09:35 GMT
Github user shazron commented on the issue:

    https://github.com/apache/cordova-ios/pull/234
  
    Recapping our chat:
    
    5 unit test failures:
    ```
    Failures:
    
      1) installPodSync throws cordova error when no pod name provided
       Message:
         Error: ENOENT: no such file or directory, open '/Users/shaz/Desktop/cordova-ios/tests/spec/unit/fixtures/testProj/platforms/ios/Podfile'
       Stacktrace:
         Error: ENOENT: no such file or directory, open '/Users/shaz/Desktop/cordova-ios/tests/spec/unit/fixtures/testProj/platforms/ios/Podfile'
      at Error (native)
      at Object.fs.openSync (fs.js:634:18)
      at Object.fs.writeFileSync (fs.js:1327:33)
      at .<anonymous> (/Users/shaz/Desktop/cordova-ios/tests/spec/unit/podMod.spec.js:33:11)
      at tryOnTimeout (timers.js:224:11)
      at Timer.listOnTimeout (timers.js:198:5)
    
    
      2) installPodSync writes to the Podfile via fs.writeFileSync
       Message:
         Error: ENOENT: no such file or directory, open '/Users/shaz/Desktop/cordova-ios/tests/spec/unit/fixtures/testProj/platforms/ios/Podfile'
       Stacktrace:
         Error: ENOENT: no such file or directory, open '/Users/shaz/Desktop/cordova-ios/tests/spec/unit/fixtures/testProj/platforms/ios/Podfile'
      at Error (native)
      at Object.fs.openSync (fs.js:634:18)
      at Object.fs.writeFileSync (fs.js:1327:33)
      at createPodfile (/Users/shaz/Desktop/cordova-ios/bin/templates/scripts/cordova/lib/podMod.js:29:8)
      at Object.addToPodfileSync (/Users/shaz/Desktop/cordova-ios/bin/templates/scripts/cordova/lib/podMod.js:124:9)
      at .<anonymous> (/Users/shaz/Desktop/cordova-ios/tests/spec/unit/podMod.spec.js:43:12)
      at tryOnTimeout (timers.js:224:11)
      at Timer.listOnTimeout (timers.js:198:5)
    
    
      3) installPodSync writes to the Podfile via fs.writeFileSync
       Message:
         Error: ENOENT: no such file or directory, open '/Users/shaz/Desktop/cordova-ios/tests/spec/unit/fixtures/testProj/platforms/ios/Podfile'
       Stacktrace:
         Error: ENOENT: no such file or directory, open '/Users/shaz/Desktop/cordova-ios/tests/spec/unit/fixtures/testProj/platforms/ios/Podfile'
      at Error (native)
      at Object.fs.openSync (fs.js:634:18)
      at Object.fs.writeFileSync (fs.js:1327:33)
      at .<anonymous> (/Users/shaz/Desktop/cordova-ios/tests/spec/unit/podMod.spec.js:33:11)
      at tryOnTimeout (timers.js:224:11)
      at Timer.listOnTimeout (timers.js:198:5)
    
    
      4) uninstallPodSync removes pod from Podfile
       Message:
         Error: ENOENT: no such file or directory, open '/Users/shaz/Desktop/cordova-ios/tests/spec/unit/fixtures/testProj/platforms/ios/Podfile'
       Stacktrace:
         Error: ENOENT: no such file or directory, open '/Users/shaz/Desktop/cordova-ios/tests/spec/unit/fixtures/testProj/platforms/ios/Podfile'
      at Error (native)
      at Object.fs.openSync (fs.js:634:18)
      at Object.fs.readFileSync (fs.js:502:33)
      at editPodfileSync (/Users/shaz/Desktop/cordova-ios/bin/templates/scripts/cordova/lib/podMod.js:33:30)
      at Object.removeFromPodfileSync (/Users/shaz/Desktop/cordova-ios/bin/templates/scripts/cordova/lib/podMod.js:140:25)
      at .<anonymous> (/Users/shaz/Desktop/cordova-ios/tests/spec/unit/podMod.spec.js:58:12)
      at tryOnTimeout (timers.js:224:11)
      at Timer.listOnTimeout (timers.js:198:5)
    
    
      5) uninstallPodSync removes pod from Podfile
       Message:
         Error: ENOENT: no such file or directory, open '/Users/shaz/Desktop/cordova-ios/tests/spec/unit/fixtures/testProj/platforms/ios/Podfile'
       Stacktrace:
         Error: ENOENT: no such file or directory, open '/Users/shaz/Desktop/cordova-ios/tests/spec/unit/fixtures/testProj/platforms/ios/Podfile'
      at Error (native)
      at Object.fs.openSync (fs.js:634:18)
      at Object.fs.writeFileSync (fs.js:1327:33)
      at .<anonymous> (/Users/shaz/Desktop/cordova-ios/tests/spec/unit/podMod.spec.js:54:8)
      at tryOnTimeout (timers.js:224:11)
      at Timer.listOnTimeout (timers.js:198:5)
    ```
    
    1. `tests/spec/unit/fixtures/testProj/platforms/ios/` does not exist in the repo. Create
a `.gitignore` so you can add the empty repo. This will make all tests pass.
    2. Remove the un-needed `fs.openSync(pathToPodfile, 'w');` in podMod.js
    3. the `tear down` is not working
         a. to have the proper sequence, you need to change `it('tests', function () {` to
`describe('tests', function () {`
         b. teardown would be better if you used fs module `fs.unlinkSync(fixturePodfile);`
    
    The pods.json tests appear to be in the cordova-lib end to end tests, so it's not covered
here.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message