cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vladimir-kotikov <...@git.apache.org>
Subject [GitHub] cordova-plugin-dialogs pull request #81: CB-11677 android: fix bug with prom...
Date Thu, 11 Aug 2016 12:58:08 GMT
Github user vladimir-kotikov commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-dialogs/pull/81#discussion_r74416632
  
    --- Diff: src/android/Notification.java ---
    @@ -286,7 +286,9 @@ public synchronized void prompt(final String message, final String
title, final
             Runnable runnable = new Runnable() {
                 public void run() {
                     final EditText promptInput =  new EditText(cordova.getActivity());
    -                promptInput.setHint(defaultText);
    +                final int promptInputColor = 0xff444444;
    --- End diff --
    
    @matrosovN, i think you should avoid using 'magic' numbers. IMO this value should be read
from resources, rather than hardcoded.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message