cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From daserge <...@git.apache.org>
Subject [GitHub] cordova-lib pull request #475: CB-11652 Update run and emulate to skip build
Date Tue, 02 Aug 2016 13:22:05 GMT
Github user daserge commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/475#discussion_r73153070
  
    --- Diff: cordova-lib/src/cordova/emulate.js ---
    @@ -42,20 +46,17 @@ module.exports = function emulate(options) {
             }).then(function() {
                 // Deploy in parallel (output gets intermixed though...)
                 return Q.all(options.platforms.map(function(platform) {
    -                // This is needed as .build modifies opts
    -                var optsClone = _.clone(options.options);
    -                return platform_lib
    -                    .getPlatformApi(platform)
    -                    .build(options.options)
    -                    .then(function() {
    -                        return hooksRunner.fire('before_deploy', options);
    -                    })
    -                    .then(function() {
    -                        optsClone.nobuild = true;
    -                        return platform_lib
    -                            .getPlatformApi(platform)
    -                            .run(optsClone);
    -                    });
    +
    +                var emulatePromise = options.options.nobuild ? Q() :
    --- End diff --
    
    Should this also be called `buildPromise`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message