cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From daserge <...@git.apache.org>
Subject [GitHub] cordova-windows pull request #190: CB-11478 Parse --archs option consistentl...
Date Tue, 02 Aug 2016 10:36:23 GMT
Github user daserge commented on a diff in the pull request:

    https://github.com/apache/cordova-windows/pull/190#discussion_r73132090
  
    --- Diff: template/cordova/lib/run.js ---
    @@ -39,7 +39,7 @@ module.exports.run = function (options) {
     
         // parse arg
         var args  = nopt({
    -        'archs': String,
    +        'archs': [String],
    --- End diff --
    
    Why do we need to change this to Array?
    What will the command usage become with this change (could you please give an example)?
    Also does it make sense to also update the tests and the docs if we make this change?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message