cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vladimir-kotikov <...@git.apache.org>
Subject [GitHub] cordova-windows pull request #185: CB-11558 Make windows plugin rm remove Pr...
Date Mon, 01 Aug 2016 10:36:01 GMT
Github user vladimir-kotikov commented on a diff in the pull request:

    https://github.com/apache/cordova-windows/pull/185#discussion_r72956629
  
    --- Diff: template/cordova/lib/PluginHandler.js ---
    @@ -105,7 +105,7 @@ var handlers = {
                 var type = obj.type;
     
                 if(type === 'projectReference') {
    -                project.removeProjectReference(path.join(plugin.dir, src), getTargetConditions(obj));
    +                project.removeProjectReference(path.join('..', '..', 'plugins', plugin.id,
src), getTargetConditions(obj));
    --- End diff --
    
    @daserge, please don't use hardcoded `../../plugins` path here. The idea here is that
PlatformApi abstracts from cordova project structure so we ideally should not rely on presence
of `plugins` directory two levels above. I'd rather calculate relative path from `plugin.dir`
using `path.relative`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message