Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 46E07200B53 for ; Tue, 12 Jul 2016 14:11:01 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 45657160A75; Tue, 12 Jul 2016 12:11:01 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 8FB63160A6A for ; Tue, 12 Jul 2016 14:11:00 +0200 (CEST) Received: (qmail 61926 invoked by uid 500); 12 Jul 2016 12:10:59 -0000 Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list dev@cordova.apache.org Received: (qmail 61915 invoked by uid 99); 12 Jul 2016 12:10:59 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 12 Jul 2016 12:10:59 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 4490BDFF68; Tue, 12 Jul 2016 12:10:59 +0000 (UTC) From: daserge To: dev@cordova.apache.org Reply-To: dev@cordova.apache.org Message-ID: Subject: [GitHub] cordova-windows pull request #185: CB-11558 Make windows plugin rm remove Pr... Content-Type: text/plain Date: Tue, 12 Jul 2016 12:10:59 +0000 (UTC) archived-at: Tue, 12 Jul 2016 12:11:01 -0000 GitHub user daserge opened a pull request: https://github.com/apache/cordova-windows/pull/185 CB-11558 Make windows plugin rm remove ProjectReference items The issue was that we have been passing a relative path during `JsprojManager`.`addProjectReference` and an absolute path during `JsprojManager`.`removeProjectReference` so that regexp failed to find and remove it. The tests were passing as they were also using absolute paths to the dummy plugin (it was not being added to the test project at all). Initial idea was to use relative paths instead for project sharing: [CB-10927 Framework references in plugin.xml file prevent Windows Universal projects from being used on other machines](https://issues.apache.org/jira/browse/CB-10927) Also updated the tests to use relative paths to the ProjectReferences. [Jira issue](https://issues.apache.org/jira/browse/CB-11558) You can merge this pull request into a Git repository by running: $ git pull https://github.com/daserge/cordova-windows CB-11558 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-windows/pull/185.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #185 ---- commit ee570036bc8faddc7d63e2830144c3d007d8e904 Author: daserge Date: 2016-07-12T11:12:48Z CB-11558 Make windows plugin rm remove ProjectReference items Also update the tests to use relative paths to the ProjectReferences ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org For additional commands, e-mail: dev-help@cordova.apache.org