Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 3AE18200B52 for ; Mon, 25 Jul 2016 10:00:08 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 397FC160A7D; Mon, 25 Jul 2016 08:00:08 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 34AB1160A78 for ; Mon, 25 Jul 2016 10:00:07 +0200 (CEST) Received: (qmail 47461 invoked by uid 500); 25 Jul 2016 08:00:06 -0000 Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list dev@cordova.apache.org Received: (qmail 47445 invoked by uid 99); 25 Jul 2016 08:00:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 25 Jul 2016 08:00:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 7537DC673B for ; Mon, 25 Jul 2016 08:00:05 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.429 X-Spam-Level: ** X-Spam-Status: No, score=2.429 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, HTML_MESSAGE=2, KAM_LIVE=1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd1-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id ePAu3KF28EWQ for ; Mon, 25 Jul 2016 08:00:01 +0000 (UTC) Received: from mail-oi0-f51.google.com (mail-oi0-f51.google.com [209.85.218.51]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 31A5A5F239 for ; Mon, 25 Jul 2016 08:00:01 +0000 (UTC) Received: by mail-oi0-f51.google.com with SMTP id l72so241673377oig.2 for ; Mon, 25 Jul 2016 01:00:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=4F5kAFHd4ZJVpS9319qkMfEmNtzLuInwjCZha/W54As=; b=R23NivVKHIEETnKZUW9Cn/NCSx1ITRyakGcWxsZ1KXFBVElb+SUTxksJW1yAtLU4FN +LPFdqed34ayl7tWxtUTvE2adnWi8E7Rj7EOmWHfyj8pjcJDNbaiZGN0VX+H7kDLHEca m3NLEvIAw7izhoxbL6zX34tU7N7F8HsUwdsA7e+s1uhtSsQtTMOr1kXcVZRn5MMGQhTZ BOvpKEfjV4v987pMv14QMLNMCf6J6UiG4wyxlehP/568Fx8a47+gfSorb0qZKSfjQrcv APFivGszIefHRrlJWpTy9ytA98Ky0YZM+we/VH+gnBsUr7FqZ4W36x6F4ZGoHr2WB40N H0/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=4F5kAFHd4ZJVpS9319qkMfEmNtzLuInwjCZha/W54As=; b=dR6hRBe0UkCMTLQFOmTARob9byXSKlmaPn8Rt144byidTVciXgEuBFqWA2tFBCbEV8 78tCxipu8lqkduK82YUuiw5UBWIKgJJ/DLJkkkDAkxmqWO4bqijLK5Y7+h+LQPtsfsfP Kyv2o+7nBIGAO3KiqtybFSCkH3DsYQvbK/DzmgteAnVLkaKtv61zyJc7wc/8W76hyRh+ ZwDH+RsuKUVNZPlF1WrK/sVipdk+FylIRBbZr8AEtD0u0l1xIoXaZOgJKD/czZbRiIkf l1AG/I4qrGL/7AJTCU/IRyJ9diMvEgo+YGN4MRwcA3GQEe8IAamtpuGQXyE5y+1zLeNC 8N1w== X-Gm-Message-State: AEkooutWVNte/I12XdnaUerd3DsF8uO6OrE8CsmicoHDpe1WN0NfzmgBk8tqFranMAAJa6leRtJr/1uoAfHCLg== X-Received: by 10.157.37.119 with SMTP id j52mr8396950otd.115.1469433599626; Mon, 25 Jul 2016 00:59:59 -0700 (PDT) MIME-Version: 1.0 Received: by 10.202.198.207 with HTTP; Mon, 25 Jul 2016 00:59:58 -0700 (PDT) In-Reply-To: References: <92CFF748-E4A3-4FF1-AEAE-D4D84DEB1839@gmail.com> From: Akila Wicky Date: Mon, 25 Jul 2016 13:29:58 +0530 Message-ID: Subject: Re: Finding a Bug fix Apache cordova To: dev@cordova.apache.org Content-Type: multipart/alternative; boundary=001a113e2b08ba55e20538712b4e archived-at: Mon, 25 Jul 2016 08:00:08 -0000 --001a113e2b08ba55e20538712b4e Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable HI all, i fixed CB-11078 fixed "Empty string for BackgroundColor preference crashes application" issue * issue https://issues.apache.org/jira/browse/CB-11078 * *pull request link https://github.com/apache/cordova-android/pull/316 *All checks have passed If this is okey Can you merge this to the main branch? On Thu, Jul 14, 2016 at 5:53 AM, Jesse wrote: > Here is the correct link, sorry for the confusion > https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=3D131 > > > > @purplecabbage > risingj.com > > On Wed, Jul 13, 2016 at 4:20 PM, Jesse wrote: > > > Oops ... the filter is private ... > > > > > > @purplecabbage > > risingj.com > > > > On Wed, Jul 13, 2016 at 4:02 PM, julio cesar sanchez < > > jcesarmobile@gmail.com> wrote: > > > >> Jesse, I get this error message > >> > >> The requested board cannot be viewed because it either does not exist = or > >> you do not have permission to view it. > >> > >> 2016-07-14 0:52 GMT+02:00 Jesse : > >> > >> > Good work Akila! > >> > > >> > I have created a board in jira for issues that are tagged as 'easyfi= x' > >> > https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=3D12= 9 > >> > > >> > These make a good starting point for anyone looking to get their fee= t > >> wet. > >> > > >> > Cheers, > >> > Jesse > >> > > >> > > >> > @purplecabbage > >> > risingj.com > >> > > >> > On Wed, Jul 13, 2016 at 12:49 AM, Akila Wicky > >> wrote: > >> > > >> > > Thank you Jesse for the support. > >> > > > >> > > All checks have passed. > >> > > > >> > > I was on the way of developing a new Feature to Apache Cordova. Th= at > >> was > >> > my > >> > > intention. Bug fixing will gave me some good knowledge about the > base. > >> > Can > >> > > you suggest some more steps learn developing a New Feature to this > >> > > platform? > >> > > > >> > > > >> > > On Wed, Jul 13, 2016 at 11:38 AM, Akila Wicky > >> wrote: > >> > > > >> > > > Hi sanjeewa, > >> > > > > >> > > > I'm already on it. > >> > > > > >> > > > Thank you > >> > > > > >> > > > On Wed, Jul 13, 2016 at 11:26 AM, Sanjeewa > > >> > > wrote: > >> > > > > >> > > >> Hi, > >> > > >> Can i work on this bug? > >> > > >> Thanks.. > >> > > >> > >> > > >> Sent from my Sony Xperia=E2=84=A2 smartphone > >> > > >> > >> > > >> ---- Jesse wrote ---- > >> > > >> > >> > > >> >The fact that you changed 64 files is probably a red flag, I > would > >> > > >> expect this to be a 1 or 2 line fix. > >> > > >> >I'll look more in the morning. > >> > > >> > > >> > > >> >> On Jul 12, 2016, at 10:27 PM, Akila Wicky > >> > wrote: > >> > > >> >> > >> > > >> >> HI all, > >> > > >> >> > >> > > >> >> i fixed CB-11078 fixed "Empty string for BackgroundColor > >> preference > >> > > >> crashes application" issue but when i pull request it to the ma= in > >> > > branch it > >> > > >> shows 2 failing and 1 successful checks. > >> > > >> >> > >> > > >> >> failing checks are continuous-integration/appveyor/pr and > >> > > >> >> > >> > > >> >> continuous-integration/travis-ci/push =E2=80=94 The Travis C= I build > >> failed > >> > > >> >> > >> > > >> >> https://github.com/apache/cordova-android/pull/315 > >> > > >> >> > >> > > >> >> Can i have some solution for this. > >> > > >> >> > >> > > >> >>> On Tue, Jul 12, 2016 at 11:08 AM, Akila Wicky < > >> asak999@gmail.com> > >> > > >> wrote: > >> > > >> >>> Hi > >> > > >> >>> > >> > > >> >>> Thank you Jesse, I accidently missed the dev list from the > >> mail.. > >> > > >> >>> I'll go through with this.. > >> > > >> >>> > >> > > >> >>>> On Tue, Jul 12, 2016 at 10:45 AM, Jesse < > >> purplecabbage@gmail.com > >> > > > >> > > >> wrote: > >> > > >> >>>> Just realized the Dev list was dropped from the last email= , > >> so I > >> > am > >> > > >> reposting so others might also benefit. > >> > > >> >>>> > >> > > >> >>>> =3D=3D=3D > >> > > >> >>>> > >> > > >> >>>> Create a new cordova app , add android, and recreate the > >> issue. > >> > > >> >>>> Once you have done that, you can open the project at > >> > > >> /platforms/android in android studio and debug the error. > >> > > >> >>>> Fix it in place, and when you are satisfied copy your > changes > >> > back > >> > > >> to you android fork. > >> > > >> >>>> Verify with your repro app and android fork by doing a : > >> > > >> >>>> Cordova platform rm android > >> > > >> >>>> Cordova platform add path-to-android-fork > >> > > >> >>>> Cordova run android > >> > > >> >>>> > >> > > >> >>>> Be sure you have copied all your changes back to your fork > >> before > >> > > >> you do the platform rm !!! > >> > > >> >>>> > >> > > >> >>>> Bonus points: add a test to prove the issue is fixed, and > >> doesn't > >> > > >> resurface. > >> > > >> >>>> > >> > > >> >>>>> On Jul 11, 2016, at 9:51 PM, Akila Wicky < > asak999@gmail.com> > >> > > wrote: > >> > > >> >>>>> > >> > > >> >>>>> Jesse, > >> > > >> >>>>> > >> > > >> >>>>> Hi, Thanks for you help in finding a bug. Can you give me > >> some > >> > way > >> > > >> to work in this bug? > >> > > >> >>>>> > >> > > >> >>>>> I forked and cloned android-cordova and build it from the > >> > sources. > >> > > >> And also i imported this project to Android Studio. Can you giv= e > me > >> > some > >> > > >> idea to approach to this bug fix. > >> > > >> >>>> > >> > > >> >>>> > >> > > >> >>>>> On Jul 7, 2016, at 1:32 PM, Akila Wicky > > >> > > wrote: > >> > > >> >>>>> > >> > > >> >>>>> Hi, > >> > > >> >>>>> > >> > > >> >>>>> > >> > > >> >>>>> Thanks, I=E2=80=99m working on it > >> > > >> >>>>> > >> > > >> >>>>>> On Fri, Jul 8, 2016 at 1:48 AM, Jesse < > >> purplecabbage@gmail.com > >> > > > >> > > >> wrote: > >> > > >> >>>>>> Here's a good one. > >> > > >> >>>>>> https://issues.apache.org/jira/browse/CB-11078 > >> > > >> >>>>>> > >> > > >> >>>>>> > >> > > >> >>>>>> > >> > > >> >>>>>> @purplecabbage > >> > > >> >>>>>> risingj.com > >> > > >> >>>>>> > >> > > >> >>>>>>> On Thu, Jul 7, 2016 at 11:54 AM, Akila Wicky < > >> > asak999@gmail.com > >> > > > > >> > > >> wrote: > >> > > >> >>>>>>> Thanks, > >> > > >> >>>>>>> > >> > > >> >>>>>>> I'm comfortable with Android.So it would be great if i > can > >> > find > >> > > a > >> > > >> stater issue with Android. > >> > > >> >>>>>>> > >> > > >> >>>>>>>> On Thu, Jul 7, 2016 at 9:59 PM, Jesse < > >> > purplecabbage@gmail.com > >> > > > > >> > > >> wrote: > >> > > >> >>>>>>>> Thanks, and Welcome Akila! > >> > > >> >>>>>>>> > >> > > >> >>>>>>>> What platforms are you most comfortable with? Android, > >> Java, > >> > > >> iOS, Obj-C, Windows, C#, js, ... > >> > > >> >>>>>>>> > >> > > >> >>>>>>>> One person's starter fix can be another person's > blocker. > >> > > >> >>>>>>>> > >> > > >> >>>>>>>> Cheers, > >> > > >> >>>>>>>> Jesse > >> > > >> >>>>>>>> > >> > > >> >>>>>>>> > On Jul 6, 2016, at 10:08 PM, Akila Wicky < > >> > asak999@gmail.com> > >> > > >> wrote: > >> > > >> >>>>>>>> > > >> > > >> >>>>>>>> > Hi everyone, I'm still a beginner to this community. > So > >> it > >> > > >> would be great > >> > > >> >>>>>>>> > if i can find a stater issue to fix as a beginning. > Can > >> you > >> > > >> help me with > >> > > >> >>>>>>>> > this? Hope i can start a good journey with this > >> > > >> >>>>>>>> > > >> > > >> >>>>>>>> > -- > >> > > >> >>>>>>>> > > >> > > >> >>>>>>>> > > >> > > >> >>>>>>>> > *Thanks and Regards,*Akila Wickramarachchi > >> > > >> >>>>>>>> > > >> > > >> >>>>>>>> > Undergraduate at University Of Peradeniya > >> > > >> >>>>>>>> > < > >> > > >> > >> > > > >> > > >> > https://www.linkedin.com/profile/view?id=3DAAMAABg_m_sBqt7aECwMPaTfYpf-ol= FytcSylC4&trk=3Dhp-identity-headline > >> > > >> > > >> > > >> >>>>>>>> > Email : asak999@gmail.com > >> > > >> >>>>>>>> > Linkedin : Akila Wickramarachchi > >> > > >> >>>>>>>> > < > >> > > >> > >> > > > >> > > >> > https://www.linkedin.com/profile/view?id=3DAAMAABg_m_sBqt7aECwMPaTfYpf-ol= FytcSylC4&trk=3Dhp-identity-name > >> > > >> > > >> > > >> >>>>>>>> > Blog : http://akilacollection.blogspot.com/ > >> > > >> >>>>>>>> > Github : https://github.com/akilawickey > >> > > >> >>>>>>> > >> > > >> >>>>>>> > >> > > >> >>>>>>> > >> > > >> >>>>>>> -- > >> > > >> >>>>>>> Thanks and Regards, > >> > > >> >>>>>>> > >> > > >> >>>>>>> Akila Wickramarachchi > >> > > >> >>>>>>> > >> > > >> >>>>>>> Undergraduate at University Of Peradeniya > >> > > >> >>>>>>> Email : asak999@gmail.com > >> > > >> >>>>>>> Linkedin : Akila Wickramarachchi > >> > > >> >>>>>>> Blog : http://akilacollection.blogspot.com/ > >> > > >> >>>>>>> Github : https://github.com/akilawickey > >> > > >> >>>>> > >> > > >> >>>>> > >> > > >> >>>>> > >> > > >> >>>>> -- > >> > > >> >>>>> Thanks and Regards, > >> > > >> >>>>> > >> > > >> >>>>> Akila Wickramarachchi > >> > > >> >>>>> > >> > > >> >>>>> Undergraduate at University Of Peradeniya > >> > > >> >>>>> Email : asak999@gmail.com > >> > > >> >>>>> Linkedin : Akila Wickramarachchi > >> > > >> >>>>> Blog : http://akilacollection.blogspot.com/ > >> > > >> >>>>> Github : https://github.com/akilawickey > >> > > >> >>> > >> > > >> >>> > >> > > >> >>> > >> > > >> >>> -- > >> > > >> >>> Thanks and Regards, > >> > > >> >>> > >> > > >> >>> Akila Wickramarachchi > >> > > >> >>> > >> > > >> >>> Undergraduate at University Of Peradeniya > >> > > >> >>> Email : asak999@gmail.com > >> > > >> >>> Linkedin : Akila Wickramarachchi > >> > > >> >>> Blog : http://akilacollection.blogspot.com/ > >> > > >> >>> Github : https://github.com/akilawickey > >> > > >> >> > >> > > >> >> > >> > > >> >> > >> > > >> >> -- > >> > > >> >> Thanks and Regards, > >> > > >> >> > >> > > >> >> Akila Wickramarachchi > >> > > >> >> > >> > > >> >> Undergraduate at University Of Peradeniya > >> > > >> >> Email : asak999@gmail.com > >> > > >> >> Linkedin : Akila Wickramarachchi > >> > > >> >> Blog : http://akilacollection.blogspot.com/ > >> > > >> >> Github : https://github.com/akilawickey > >> > > >> > >> > > > > >> > > > > >> > > > > >> > > > -- > >> > > > > >> > > > > >> > > > *Thanks and Regards,*Akila Wickramarachchi > >> > > > > >> > > > Undergraduate at University Of Peradeniya > >> > > > < > >> > > > >> > > >> > https://www.linkedin.com/profile/view?id=3DAAMAABg_m_sBqt7aECwMPaTfYpf-ol= FytcSylC4&trk=3Dhp-identity-headline > >> > > > > >> > > > Email : asak999@gmail.com > >> > > > Linkedin : Akila Wickramarachchi > >> > > > < > >> > > > >> > > >> > https://www.linkedin.com/profile/view?id=3DAAMAABg_m_sBqt7aECwMPaTfYpf-ol= FytcSylC4&trk=3Dhp-identity-name > >> > > > > >> > > > Blog : http://akilacollection.blogspot.com/ > >> > > > Github : https://github.com/akilawickey > >> > > > > >> > > > >> > > > >> > > > >> > > -- > >> > > > >> > > > >> > > *Thanks and Regards,*Akila Wickramarachchi > >> > > > >> > > Undergraduate at University Of Peradeniya > >> > > < > >> > > > >> > > >> > https://www.linkedin.com/profile/view?id=3DAAMAABg_m_sBqt7aECwMPaTfYpf-ol= FytcSylC4&trk=3Dhp-identity-headline > >> > > > > >> > > Email : asak999@gmail.com > >> > > Linkedin : Akila Wickramarachchi > >> > > < > >> > > > >> > > >> > https://www.linkedin.com/profile/view?id=3DAAMAABg_m_sBqt7aECwMPaTfYpf-ol= FytcSylC4&trk=3Dhp-identity-name > >> > > > > >> > > Blog : http://akilacollection.blogspot.com/ > >> > > Github : https://github.com/akilawickey > >> > > > >> > > >> > > > > > --=20 *Thanks and Regards,*Akila Wickramarachchi Undergraduate at University Of Peradeniya Email : asak999@gmail.com Linkedin : Akila Wickramarachchi Blog : http://akilacollection.blogspot.com/ Github : https://github.com/akilawickey --001a113e2b08ba55e20538712b4e--