Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
From: dpogue <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-469-cordova-lib@git.apache.org>
In-Reply-To: <git-pr-469-cordova-lib@git.apache.org>
Subject: [GitHub] cordova-lib pull request #469: CB-8320: We look for a build.gradle to make s...
Content-Type: text/plain
Message-Id: <20160728191928.4F375E0100@git1-us-west.apache.org>
Date: Thu, 28 Jul 2016 19:19:28 +0000 (UTC)
archived-at: Thu, 28 Jul 2016 19:19:30 -0000

Github user dpogue commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/469#discussion_r72685014
  
    --- Diff: cordova-lib/src/cordova/metadata/android_parser.js ---
    @@ -31,14 +31,20 @@ var fs            = require('fs'),
     
     
     function android_parser(project) {
    -    if (!fs.existsSync(path.join(project, 'AndroidManifest.xml'))) {
    +    if (!fs.existsSync(path.join(project, 'build.gradle'))) {
             throw new CordovaError('The provided path "' + project + '" is not an Android project.');
         }
     
         // Call the base class constructor
         Parser.call(this, 'android', project);
     
         this.path = project;
    +
    +    //If we have a gradle file but not a manifest, this is an Android Studio project
    +    if(!fs.existsSync(path.join(project, "AndroidManifest.xml"))) {
    --- End diff --
    
    @infil00p Apparently this fails the jslint step because of double quotes here, which is why the Travis and Appveyor builds failed. It wants all JS strings to use single quotes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org