Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
From: juliascript <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-234-cordova-ios@git.apache.org>
In-Reply-To: <git-pr-234-cordova-ios@git.apache.org>
Subject: [GitHub] cordova-ios pull request #234: CB-9825 cocoapod integration for plugins
Content-Type: text/plain
Message-Id: <20160712233546.1434CDFF68@git1-us-west.apache.org>
Date: Tue, 12 Jul 2016 23:35:45 +0000 (UTC)
archived-at: Tue, 12 Jul 2016 23:35:48 -0000

Github user juliascript commented on a diff in the pull request:

    https://github.com/apache/cordova-ios/pull/234#discussion_r70541974
  
    --- Diff: bin/templates/scripts/cordova/lib/podMod.js ---
    @@ -0,0 +1,162 @@
    +var fs = require('fs');
    +var util = require('util');
    +var events = require('cordova-common').events;
    +var superspawn = require('cordova-common').superspawn;
    +var CordovaError = require('cordova-common').CordovaError;
    +var opts = {};
    +/*
    +-- After pods are installed in a .xcworkspace, all existing ios code needs to go into the WORKSPACE file -- will need to 
    +    create a workspace file and then embed the Xcode project  
    +
    +        - Holly might have done some work on this, see the docs: 
    +          https://github.com/phonegap/phonegap-webview-ios not sure how applicable it can be to our case
    +*/
    +function removeProjectFromPath (pathToProjectFile) {
    +    var array = [];
    +    //remove the project from the path
    +    array = pathToProjectFile.split('/');
    +    array.pop();
    +    var path = array.join('/');
    +    return path;
    +}
    +
    +function createPodfile (projectName, pathToProjectFile) {
    +    var path = removeProjectFromPath(pathToProjectFile);
    +    var pathToPodfile = path + '/Podfile';
    +    var podfileText = util.format('platform :ios, \'8.0\'\n\ntarget \'%s\' do\n\n  project \'%s\'\n\n  \n\nend' , projectName, pathToProjectFile);
    +    fs.writeFileSync(pathToPodfile, podfileText);
    +}
    +
    +function editPodfileSync (Podfile, pod, isRemoval) {
    +    var podfileContents = fs.readFileSync(Podfile, 'utf8');
    +    //split by \n, add in the pod after the project line, shift the rest down
    +    var podfileContentsArray = podfileContents.split('\n');
    +    var linesInPodfileToKeep = [];
    +
    +    if (isRemoval) {
    +        podfileContentsArray.forEach (function (lineInPodfile) {
    +            //if the line in Podfile is the pod to rm, don't save it to new array (to be returned)
    +            if (!lineInPodfile.includes(pod)){
    +                linesInPodfileToKeep.push(lineInPodfile); 
    +            }
    +        });
    +        podfileContents = linesInPodfileToKeep.join('\n');
    +    } else {
    +        podfileContentsArray.splice(5, 0, pod);
    --- End diff --
    
    5 is the line in the Podfile that I am injecting the new pod. Added a var to improve readability. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org