cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From riknoll <...@git.apache.org>
Subject [GitHub] cordova-lib pull request #472: CB-11645: Check for getEditConfigs before inv...
Date Fri, 29 Jul 2016 23:27:04 GMT
GitHub user riknoll opened a pull request:

    https://github.com/apache/cordova-lib/pull/472

    CB-11645: Check for getEditConfigs before invoking it on pluginInfo

    Adding a guard to prevent a type error when platforms and CLI have mismatching cordova-common
versions. The issue here is that the `PluginInfo` object crosses the platform API barrier
between the two so when 5fb8dffb2dc92e4d08d286432f23299da0e812 added `getEditConfigs`, it
ended up being a breaking change. This just checks for the function and ignores `edit-config`
changes if it is not defined. More permanent fix might be to move its functionality elsewhere
so that it does not cross the platform API barrier. Plugins that rely on `edit-config` (which
should be none at this point) should [specify the platform and cordova cli version they need](http://cordova.apache.org/docs/en/latest/guide/hybrid/plugins/index.html#specifying-cordova-dependencies)
in package.json.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/riknoll/cordova-lib edit-config-fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-lib/pull/472.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #472
    
----
commit 72074609c931177db9810723b4ee3425cf9e6b58
Author: Richard Knoll <riknoll@microsoft.com>
Date:   2016-07-29T23:19:11Z

    CB-11645: Check for getEditConfigs before invoking it on pluginInfo

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message