cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dpogue <...@git.apache.org>
Subject [GitHub] cordova-lib pull request #464: CB-11589: Fix missing plugin files after rest...
Date Fri, 15 Jul 2016 18:36:49 GMT
GitHub user dpogue opened a pull request:

    https://github.com/apache/cordova-lib/pull/464

    CB-11589: Fix missing plugin files after restore

    This avoid running prepare unnecessarily when restoring platforms as part of a prepare.
This solves warnings about plugins already being installed, is a performance improvement,
and fixes the weird case where I was getting an empty ios.json file after restoring plugins.
    
    One thing that isn't clear to me is why `options.save` gets passed through the restore
process. Restore is, by definition, adding stuff that has already been saved, so there should
be no case in which that ever saves new platforms/plugins to config.xml?
    
    /cc @vladimir-kotikov @riknoll @stevengill 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dpogue/cordova-lib restore-install

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-lib/pull/464.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #464
    
----
commit 80e93313a4f27ea987adff2270b50994edd762dd
Author: Darryl Pogue <darryl@ayogo.com>
Date:   2016-07-15T18:23:27Z

    CB-11589: Fix missing plugin files after restore

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message