cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From NickyYo <...@git.apache.org>
Subject [GitHub] cordova-plugin-network-information pull request #45: Update NetworkManager.j...
Date Tue, 05 Jul 2016 10:09:33 GMT
GitHub user NickyYo opened a pull request:

    https://github.com/apache/cordova-plugin-network-information/pull/45

    Update NetworkManager.java

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    
    
    ### What does this PR do?
    
    
    ### What testing has been done on this change?
    
    
    ### Checklist
    - [ ] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and submitted to
secretary@apache.org.
    - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.
    
    Networkmanager.java broken for Android, missing bracket.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/NickyYo/cordova-plugin-network-information master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-network-information/pull/45.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #45
    
----
commit eaea5fd2554f4d6c7eebe2139efb36e74c0a1c7e
Author: NickyYo <nickmit87@gmail.com>
Date:   2016-07-05T10:07:31Z

    Update NetworkManager.java
    
    Broken if.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message