cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cjpearson <>
Subject [GitHub] cordova-plugins pull request #26: CB-11643: return after sending error
Date Fri, 29 Jul 2016 14:19:16 GMT
GitHub user cjpearson opened a pull request:

    CB-11643: return after sending error

    ### Platforms affected
    ### What does this PR do?
    After an error is returned, we should return and not process the request. Continuing to
process the request can cause a crash.
    ### What testing has been done on this change?
    Tested on a device with the sample app, adding the following code.
    document.getElementById("deviceready").addEventListener("click", function buttonClick()
                var fail = function () { console.log("failure"); }
                var photoSuccess = function (uri) {
                    var img = document.createElement("img");
                    img.src = uri;
      , fail, {
                            saveToPhotoAlbum: false
    ### Checklist
    - [X] [ICLA]( has been signed and submitted to
    - [X] [Reported an issue]( in the JIRA
    - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [] Added automated test coverage as appropriate for this change.

You can merge this pull request into a Git repository by running:

    $ git pull webserver-crash

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #26
commit 2568693862556a712fdf760487a9d3f6f0ffb5f9
Author: Connor Pearson <>
Date:   2016-07-29T14:15:01Z

    CB-11643: return after sending error


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message