cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jcesarmobile <...@git.apache.org>
Subject [GitHub] cordova-plugin-camera pull request #226: CB-11376: (ios): fix CameraUsesGeol...
Date Sun, 31 Jul 2016 18:21:16 GMT
GitHub user jcesarmobile opened a pull request:

    https://github.com/apache/cordova-plugin-camera/pull/226

    CB-11376: (ios): fix CameraUsesGeolocation error

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    iOS
    
    ### What does this PR do?
    The plugin was sending the result twice, the first one as soon as the user takes the picture
and the second one when the geolocation success or fails. On the second one the callbackId
was null because it is set to null on the first one.
    
    If the user is using CameraUsesGeolocation, the plugin doesn't have to send the first
result when the picture is taken, it has to wait until the geolocation success or fails and
then send the image with the geolocation data.
    
    ### What testing has been done on this change?
    Tested on real devices (iOS 8 and iOS 9)
    
    ### Checklist
    - [X] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and submitted to
secretary@apache.org.
    - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jcesarmobile/cordova-plugin-camera CB-11376

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-camera/pull/226.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #226
    
----
commit 1f62944638146288e7898d2656091da8bf746b57
Author: Julio C├ęsar <jcesarmobile@gmail.com>
Date:   2016-07-31T18:15:49Z

    CB-11376: (ios): fix CameraUsesGeolocation error

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message