cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jcesarmobile <...@git.apache.org>
Subject [GitHub] cordova-plugin-camera pull request #224: CB-11410: (ios) fix cameraPopoverHa...
Date Sun, 31 Jul 2016 15:16:31 GMT
GitHub user jcesarmobile opened a pull request:

    https://github.com/apache/cordova-plugin-camera/pull/224

    CB-11410: (ios) fix cameraPopoverHandle.setPosition

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    iOS
    
    ### What does this PR do?
    fix cameraPopoverHandle.setPosition
    
    You have to dismiss the existing popover before presenting it on a new possition or it
won't work
    
    ### What testing has been done on this change?
    Tested on iOS 8 and iOS 9 iPads
    
    ### Checklist
    - [X] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and submitted to
secretary@apache.org.
    - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jcesarmobile/cordova-plugin-camera CB-11410

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-camera/pull/224.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #224
    
----
commit 9677a8056ed498f1eca1e2eae7e522373d8703aa
Author: Julio C├ęsar <jcesarmobile@gmail.com>
Date:   2016-07-31T15:13:57Z

    CB-11410: (ios) fix cameraPopoverHandle.setPosition

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message