cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From daserge <...@git.apache.org>
Subject [GitHub] cordova-plugin-file pull request #186: CB-11305 Enable cdvfile: assets fs ro...
Date Tue, 05 Jul 2016 12:30:03 GMT
GitHub user daserge opened a pull request:

    https://github.com/apache/cordova-plugin-file/pull/186

    CB-11305 Enable cdvfile: assets fs root for DOM requests

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    Android
    
    ### What does this PR do?
    * Added test for cdvfile applicationDirectory fs root
    * Updated the docs and added the assets to Android available fs roots list
    * Allow cdvfile: access for android automatically
    
    ### What testing has been done on this change?
    Jasmine auto and manual tests, app tests (see [Jira](https://issues.apache.org/jira/browse/CB-11305))
    
    ### Checklist
    - [x] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and submitted to
secretary@apache.org.
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [x] Added automated test coverage as appropriate for this change.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/daserge/cordova-plugin-file CB-11305

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-file/pull/186.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #186
    
----
commit 2cdccb7f4734365d9840667359c7c5502b0038f4
Author: daserge <v-seshak@microsoft.com>
Date:   2016-07-05T12:27:21Z

    CB-11305 Enable cdvfile: assets fs root for DOM requests
    
    Added test for cdvfile applicationDirectory fs root
    Updated the docs and added the assets to Android available fs roots list
    Allow cdvfile: access for android automatically

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message