cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rpc1910 <...@git.apache.org>
Subject [GitHub] cordova-plugin-inappbrowser pull request #173: Add property enablepictureinp...
Date Fri, 08 Jul 2016 12:52:29 GMT
GitHub user rpc1910 opened a pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/173

    Add property enablepictureinpicture in iOS

    ### Platforms affected
    iOS
    
    ### What does this PR do?
    Adding configuration option to disable/enabled the picture in picture option in versions
of iOS 9.0 or later.
    
    https://developer.apple.com/library/ios/documentation/WindowsViews/Conceptual/AdoptingMultitaskingOniPad/QuickStartForPictureInPicture.html
    
    
    ### What testing has been done on this change?
    Compilation and run on iOS 8.1 and 9.3.
    
    ### Checklist
    - [ ] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and submitted to
secretary@apache.org.
    - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rpc1910/cordova-plugin-inappbrowser master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/173.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #173
    
----
commit 375206e620ed6af14b03c5b2953224c5e9e785dd
Author: Rodrigo Passos <rodrigo.passos25@gmail.com>
Date:   2016-07-08T12:10:39Z

    Add property enablepictureinpicture on iOS

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message