cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugnano <...@git.apache.org>
Subject [GitHub] cordova-plugin-splashscreen pull request #110: Fix crash on iOS when reloadi...
Date Thu, 21 Jul 2016 15:21:56 GMT
GitHub user bugnano opened a pull request:

    https://github.com/apache/cordova-plugin-splashscreen/pull/110

    Fix crash on iOS when reloading page from remote Safari

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    iOS
    
    ### What does this PR do?
    Fix a crash when calling navigator.splashscreen.hide() after reloading the page from a
remote Safari
    
    ### What testing has been done on this change?
    - Create an application with AutoHideSplashScreen set to false
    - Call navigator.splashscreen.hide() from the application
    - Connect Safari from a Mac to debug the application
    - Hit the reload button from Safari
    - Without this patch, the application crashes
    - With this patch, the page is reloaded without any problem
    
    ### Checklist
    - [ ] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and submitted to
secretary@apache.org.
    - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bugnano/cordova-plugin-splashscreen master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-splashscreen/pull/110.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #110
    
----
commit 16eceaa170aae27c992728337bee3090ebed0e0d
Author: Franco Bugnano <franco@bugnano.it>
Date:   2016-07-21T15:14:42Z

    Fix crash on iOS when reloading page from remote Safari

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message