cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nleclerc <...@git.apache.org>
Subject [GitHub] cordova-plugin-media-capture issue #65: CB-10180: (iOS) implement the 'quali...
Date Sun, 31 Jul 2016 21:45:57 GMT
Github user nleclerc commented on the issue:

    https://github.com/apache/cordova-plugin-media-capture/pull/65
  
    If i may, i think that default behavior not being one of the explicit choices available
is a bad idea.
    It doesn't allow you to proof your code against default behavior changes.
    
    I submitted another PR (https://github.com/apache/cordova-plugin-media-capture/pull/48)
to implement video quality in iOS but the real problem is that whoever made the android quality
change did quite a bad job at it.
    
    If we don't want to end up with stupid options (like 0 low, 1 high and 2 medium) we're
gonna have to break compatibility.
    Or Maybe we could use some String option values to have more verbose quality levels and
keep the numeric ones to maintain compatibility.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message