cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jcesarmobile <...@git.apache.org>
Subject [GitHub] cordova-plugin-statusbar issue #55: Handle extended status bar on iOS
Date Sat, 30 Jul 2016 21:59:47 GMT
Github user jcesarmobile commented on the issue:

    https://github.com/apache/cordova-plugin-statusbar/pull/55
  
    Hi.
    Sorry that it took me so long to review this.
    As you were using the hardcoded value 20 for the statusbar height I had to ask on the
developer list, because on another plugin I saw a comment telling that we shouldn't hardcode
the statusbar height to 20 in case Apple changes it in the future. But we are ok on using
20 in this case as there is no other way of fixing it.
    
    Just a few things.
    First of all, I haven't seen you on the list of apache contributors. Before we can merge
it, you need to sign Apache's Contributor License Agreement (can be done online): http://www.apache.org/licenses/#clas
    
    Second: just a few code changes. Can you move this common lines before the if?
    
    ```
    CGRect statusBarFrame = [UIApplication sharedApplication].statusBarFrame;
    statusBarFrame = [self invertFrameIfNeeded:statusBarFrame];
    CGRect frame = self.webView.frame;
    ```
    
    And this common line after the else?
    
    `self.webView.frame = frame;`
    
    just to not have it duplicated.
    
    Thanks



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message