cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From riknoll <>
Subject [GitHub] cordova-lib issue #473: CB-11645 added check to see if getEditConfig exists ...
Date Sat, 30 Jul 2016 00:52:15 GMT
Github user riknoll commented on the issue:
    The only other consideration I can think of off the top of my head is that the edit-config
stuff also made changes to the android.json (and other equivalent platform files) for edit-config
support. They aren't breaking changes as far as I know because I don't think the information
that is saved for the old config-file tag was altered (@ktop to confirm).
    I believe the `PluginInfo` object is the only thing used in the platform API that has
changed. It might be worth someone else taking a look at the APIs that changed and where they
get used, though.
    To avoid subtle breaks like this in the future, we should probably better delineate what
objects are part of the platform API and what are not. The `PluginInfo` object gets used all
over and it isn't immediately obvious that altering it could cause effects like this (especially
when using it in other files in the same repo).

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message