cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dpogue <...@git.apache.org>
Subject [GitHub] cordova-lib pull request #469: CB-8320: We look for a build.gradle to make s...
Date Thu, 28 Jul 2016 19:19:28 GMT
Github user dpogue commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/469#discussion_r72685014
  
    --- Diff: cordova-lib/src/cordova/metadata/android_parser.js ---
    @@ -31,14 +31,20 @@ var fs            = require('fs'),
     
     
     function android_parser(project) {
    -    if (!fs.existsSync(path.join(project, 'AndroidManifest.xml'))) {
    +    if (!fs.existsSync(path.join(project, 'build.gradle'))) {
             throw new CordovaError('The provided path "' + project + '" is not an Android
project.');
         }
     
         // Call the base class constructor
         Parser.call(this, 'android', project);
     
         this.path = project;
    +
    +    //If we have a gradle file but not a manifest, this is an Android Studio project
    +    if(!fs.existsSync(path.join(project, "AndroidManifest.xml"))) {
    --- End diff --
    
    @infil00p Apparently this fails the jslint step because of double quotes here, which is
why the Travis and Appveyor builds failed. It wants all JS strings to use single quotes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message