cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From TimBarham <...@git.apache.org>
Subject [GitHub] cordova-windows pull request #188: Fix issues where MSBuild cannot be found ...
Date Thu, 21 Jul 2016 21:31:45 GMT
Github user TimBarham commented on a diff in the pull request:

    https://github.com/apache/cordova-windows/pull/188#discussion_r71791061
  
    --- Diff: template/cordova/lib/MSBuildTools.js ---
    @@ -93,6 +93,20 @@ module.exports.findAllAvailableVersions = function () {
                 return !!item;
             });
         });
    +}
    +
    +module.exports.findAllAvailableVersions = function () {
    +    // CB-11548 use VSINSTALLDIR environment if defined to find MSBuild. If VSINSTALLDIR
    +    // is not specified or incorrect - fall back to default discovery mechanism.
    --- End diff --
    
    It is quite likely that `VSINSTALLDIR` is specified and *correct*, but just doesn't contain
the msbuild path we're looking for (this will be the case for previous versions of VS, for
example). So I think it would be clearer to say here something like "not specified or doesn't
contain the MSBuild path we are looking for".


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message