cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jcesarmobile <>
Subject [GitHub] cordova-plugin-inappbrowser pull request #170: fix some calls which used api...
Date Tue, 19 Jul 2016 19:41:38 GMT
Github user jcesarmobile commented on a diff in the pull request:
    --- Diff: src/android/ ---
    @@ -579,11 +579,13 @@ public void run() {
                     Resources activityRes = cordova.getActivity().getResources();
                     int backResId = activityRes.getIdentifier("ic_action_previous_item",
"drawable", cordova.getActivity().getPackageName());
                     Drawable backIcon = activityRes.getDrawable(backResId);
    -                back.setBackground(null);
    +                if (Build.VERSION.SDK_INT >= 16)
    +                    back.setBackground(null);
                     back.setPadding(0, this.dpToPixels(10), 0, this.dpToPixels(10));
    -                back.getAdjustViewBounds();
    +                if (Build.VERSION.SDK_INT >= 16)
    +                    back.getAdjustViewBounds();
    --- End diff --
    Yeah, I don't think it makes anything as it's a get, it returns true or false and the
value is not being used anywhere or stored on a variable

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message