cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jcesarsh <...@git.apache.org>
Subject [GitHub] cordova-android pull request #316: CB-11078 Empty string for BackgroundColor...
Date Wed, 13 Jul 2016 23:01:26 GMT
Github user jcesarsh commented on a diff in the pull request:

    https://github.com/apache/cordova-android/pull/316#discussion_r70723738
  
    --- Diff: test/res/xml/config.xml ---
    @@ -35,6 +35,7 @@
         <preference name="useBrowserHistory" value="true" />
         <preference name="exit-on-suspend" value="false" />
         <preference name="showTitle" value="true" />
    +    <preference name="BackgroundColor" value="true" />
    --- End diff --
    
    If you want to fix "empty string" crash shouldn't you do the test with an empty string?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message