cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vladimir-kotikov <>
Subject [GitHub] cordova-lib pull request #460: CB-11491 Introduce before_deploy hook
Date Mon, 04 Jul 2016 10:12:02 GMT
Github user vladimir-kotikov commented on a diff in the pull request:
    --- Diff: cordova-lib/spec-cordova/emulate.spec.js ---
    @@ -82,7 +85,7 @@ describe('emulate command', function() {
                 cordova.raw.emulate({platforms: ['ios'], options: {optionTastic: true }}).then(function(err)
    -                expect({ device: false, emulator:
true, optionTastic: true });
    +                expect({ device: false, emulator:
true, optionTastic: true, nobuild: true });
    --- End diff --
    @daserge, could you please add another expectation to check if `build` also had been called
and changing the options in `build` does not affect `run` command?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message