Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 9AA17200AC8 for ; Tue, 7 Jun 2016 19:18:10 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 9970E160A36; Tue, 7 Jun 2016 17:18:10 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 156E5160968 for ; Tue, 7 Jun 2016 19:18:09 +0200 (CEST) Received: (qmail 85596 invoked by uid 500); 7 Jun 2016 17:18:09 -0000 Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list dev@cordova.apache.org Received: (qmail 85584 invoked by uid 99); 7 Jun 2016 17:18:08 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 07 Jun 2016 17:18:08 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id BE57EDFC7E; Tue, 7 Jun 2016 17:18:08 +0000 (UTC) From: rob-close To: dev@cordova.apache.org Reply-To: dev@cordova.apache.org Message-ID: Subject: [GitHub] cordova-plugin-file pull request #183: CB-11385 android: Does not pass sonar... Content-Type: text/plain Date: Tue, 7 Jun 2016 17:18:08 +0000 (UTC) archived-at: Tue, 07 Jun 2016 17:18:10 -0000 GitHub user rob-close opened a pull request: https://github.com/apache/cordova-plugin-file/pull/183 CB-11385 android: Does not pass sonarqube scan The problem are "Empty Catch Block", which sonarqube considers a blocker, and the following, which sonarqube considers major: Preserve stack trace, Reliance on default encoding. You can merge this pull request into a Git repository by running: $ git pull https://github.com/rob-close/cordova-plugin-file master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-file/pull/183.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #183 ---- commit c10a71acf1ccd9d61c9e465f91587dd020238edb Author: Rob Close Date: 2016-06-07T17:15:26Z CB-11385 android: Does not pass sonarqube scan The problem are "Empty Catch Block", which sonarqube considers a blocker, and the following, which sonarqube considers major: Preserve stack trace, Reliance on default encoding. ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org For additional commands, e-mail: dev-help@cordova.apache.org