Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
MIME-Version: 1.0
In-Reply-To: <CAD6pGjwKCzMHKCN6VbaCqbfBVvd1wsWNUPaApUU6KNuiw=nEyw@mail.gmail.com>
References: <CAD6pGjzGfh3hbGu8aP3+VqYYX1DTp=5rqA3dgs6wYnSA2CiAWQ@mail.gmail.com>
 <CAE6O_-YWrKYm91jje1FeYU0oD1iN06_i4Vdops0JM5iv-PJ-fQ@mail.gmail.com>
 <CAD6pGjy+KcHKT-ykCTAj0zk=fHr4eQzLRHOD_FaArNJZezMivA@mail.gmail.com> <CAD6pGjwKCzMHKCN6VbaCqbfBVvd1wsWNUPaApUU6KNuiw=nEyw@mail.gmail.com>
From: Shazron <shazron@gmail.com>
Date: Fri, 17 Jun 2016 15:15:54 -0700
Message-ID: <CAE6O_-ZvtsOCQGVsNHgGadWJs34hCHo6GNnWuB97sPCSwR_=mw@mail.gmail.com>
Subject: Re: [Discuss] Why was device.name removed from the device-plugin?
To: "dev@cordova.apache.org" <dev@cordova.apache.org>
Content-Type: multipart/alternative; boundary=001a113c786c143fc0053580b530
archived-at: Fri, 17 Jun 2016 22:16:44 -0000

--001a113c786c143fc0053580b530
Content-Type: text/plain; charset=UTF-8

I have no objection if the API property is unambiguous, unlike what it was
before (over 4 years ago!), and is supported by all the major platforms
(looks like it is, from what you mentioned). Also -- Ubuntu/Linux looks
like its just /etc/hostname. We'll just have to bump a minor version.

What do the others think?


On Fri, Jun 17, 2016 at 3:07 PM, Philipp Kursawe <phil.kursawe@gmail.com>
wrote:

> To further emphasize one point. I fully agree with moving from device.name
> to device.model + device.manufacturer + device.platform.
> But I still ask all of you do consider bringing back a proper device.name.
> As I wrote, on Windows its pretty easy to get the real name of the
> PC/Phone. On iOS and Android the work is already done.
>
> On Sat, Jun 18, 2016 at 12:02 AM, Philipp Kursawe <phil.kursawe@gmail.com>
> wrote:
>
> > Thanks for pointing this out. However the name is not used to reference
> > the device to the API. Thats what the device.uuid is being used for. The
> > device name is used in the UI where the user can see its API enabled
> > devices. You don't want to show the user the device id there (cause she
> has
> > no point of reference to which physical device it belongs) but the name
> she
> > gave her phone and knows her phone when she connects it to itunes, iphoto
> > etc.
> >
> > So the reason to introduce the name property back is exactly the one you
> > mentioned: The user can always change the name of her phone and there
> knows
> > its name and will recognize it in a list of devices.
> >
> > On Fri, Jun 17, 2016 at 9:23 PM, Shazron <shazron@gmail.com> wrote:
> >
> >> Hi Philipp,
> >> This was the rationale:
> >>
> >>
> https://lists.apache.org/thread.html/e3b0e5f87ba3929d5578308b25ee9a6af5b91177b94015878970fa8e@1352248856@%3Cdev.cordova.apache.org%3E
> >>
> >> On iOS,  [UIDevice name] returns the name the user sets in iTunes for
> >> their
> >> device i.e. "Shazron's iPhone 4", and can change anytime so relying on
> it
> >> for API access would be problematic.
> >>
> >>
> >> On Fri, Jun 17, 2016 at 1:51 AM, Philipp Kursawe <
> phil.kursawe@gmail.com>
> >> wrote:
> >>
> >> > I wonder why such an important piece of information is not provided
> >> anymore
> >> > in the device plugin?
> >> > What was the reason to remove the property?
> >> >
> >> > The name of the device, especially when users can authorise/revoke API
> >> > access to apps on different devices, is an important variable to know.
> >> >
> >> > There is a plugin that brings back this functionality for Android, iOS
> >> and
> >> > for Windows it would be a one-liner only too.
> >> > https://github.com/becvert/cordova-plugin-device-name
> >> >
> >>
> >
> >
>

--001a113c786c143fc0053580b530--