Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 88465200B34 for ; Sat, 18 Jun 2016 00:08:08 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 870DE160A62; Fri, 17 Jun 2016 22:08:08 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id CEFA7160A61 for ; Sat, 18 Jun 2016 00:08:07 +0200 (CEST) Received: (qmail 7649 invoked by uid 500); 17 Jun 2016 22:08:02 -0000 Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list dev@cordova.apache.org Received: (qmail 7635 invoked by uid 99); 17 Jun 2016 22:08:01 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 17 Jun 2016 22:08:01 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 41A89180BD9 for ; Fri, 17 Jun 2016 22:08:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.179 X-Spam-Level: * X-Spam-Status: No, score=1.179 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd3-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx2-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 6bnD2ubWS1lE for ; Fri, 17 Jun 2016 22:07:59 +0000 (UTC) Received: from mail-lf0-f54.google.com (mail-lf0-f54.google.com [209.85.215.54]) by mx2-lw-eu.apache.org (ASF Mail Server at mx2-lw-eu.apache.org) with ESMTPS id 8DA065F1F7 for ; Fri, 17 Jun 2016 22:07:58 +0000 (UTC) Received: by mail-lf0-f54.google.com with SMTP id l188so6337198lfe.2 for ; Fri, 17 Jun 2016 15:07:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=l28G94gTHDCQpTYg+chYfsFg3PR16SVWts2FCYg6N70=; b=sT9mnjzCFR6vIc0QgqV84jRJ9jC4y9Cc2DW1ZDFteA8jqWkfYEDlo2j5uvx+02yY0C SFs3DSWaeZaoMIWZrGNcpD+RIuE74OX9jZ61JiJBgKZEI36QIPYuHP6SIc7UDq12IIeS OsSL7Xm/Mz6ofDrFU5XWwI5Zbkv0szHaXNEsuvZVnk54xNuSQS+uTYgx4goRSpWI1hPN mxd0Jxm1q5qtRFni/fL1lfIu9S4RAMorhXF/H6etDklkruXg1NNCPDOGTawvWr6tTLFi 5TXAGtKACNLCjx0ak4S5P248QSrNrPGNntMo8vu47icsMwisAVmfoXrb7jK64eyJKZEx Yg+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=l28G94gTHDCQpTYg+chYfsFg3PR16SVWts2FCYg6N70=; b=SgIkou5ExkbuAtOh2HoOslME+/tAi+5Q1jjnkvtnSqtjyxpU8vXS1qUnuTAj5vLjsP hyZ1A32c+aYAB0eb7Utr4UjL1Yxt1eaquNPk/fLZ1cxrplJaRMEhpYOBJ5i6Ottrz/GQ 8p2iSB8qdzP0M1T0xLZcH/7p3zVVfJ5iaoKx/DV0Wn8J2OJ2Wi/8vypo4TIwwvUNFdIz pjvcW8nfHJMiq/4/+9tKt0rPzjIzgJhOIr6tTUbh9Q/xXATelRRuC6FM3agkMG0eDszs RQPiJkB9dYwePIgEEfLS9QbzK6EqTGzY1P8H4V1N/4o+nueS2qNVmzi/CjdlLHQBScOu Oukw== X-Gm-Message-State: ALyK8tLNDKPmSiSA+zjZKr4CY/STyu/1KEcZxFKQB8J5cvfQ6rksKWY0elBfA5pJ4JMteMQ8jgWWX5HPQOmrlw== X-Received: by 10.46.9.80 with SMTP id 77mr1198051ljj.0.1466201277884; Fri, 17 Jun 2016 15:07:57 -0700 (PDT) MIME-Version: 1.0 Received: by 10.25.148.208 with HTTP; Fri, 17 Jun 2016 15:07:38 -0700 (PDT) In-Reply-To: References: From: Philipp Kursawe Date: Sat, 18 Jun 2016 00:07:38 +0200 Message-ID: Subject: Re: [Discuss] Why was device.name removed from the device-plugin? To: dev@cordova.apache.org Content-Type: multipart/alternative; boundary=001a114b0d1856702c053580963d archived-at: Fri, 17 Jun 2016 22:08:08 -0000 --001a114b0d1856702c053580963d Content-Type: text/plain; charset=UTF-8 To further emphasize one point. I fully agree with moving from device.name to device.model + device.manufacturer + device.platform. But I still ask all of you do consider bringing back a proper device.name. As I wrote, on Windows its pretty easy to get the real name of the PC/Phone. On iOS and Android the work is already done. On Sat, Jun 18, 2016 at 12:02 AM, Philipp Kursawe wrote: > Thanks for pointing this out. However the name is not used to reference > the device to the API. Thats what the device.uuid is being used for. The > device name is used in the UI where the user can see its API enabled > devices. You don't want to show the user the device id there (cause she has > no point of reference to which physical device it belongs) but the name she > gave her phone and knows her phone when she connects it to itunes, iphoto > etc. > > So the reason to introduce the name property back is exactly the one you > mentioned: The user can always change the name of her phone and there knows > its name and will recognize it in a list of devices. > > On Fri, Jun 17, 2016 at 9:23 PM, Shazron wrote: > >> Hi Philipp, >> This was the rationale: >> >> https://lists.apache.org/thread.html/e3b0e5f87ba3929d5578308b25ee9a6af5b91177b94015878970fa8e@1352248856@%3Cdev.cordova.apache.org%3E >> >> On iOS, [UIDevice name] returns the name the user sets in iTunes for >> their >> device i.e. "Shazron's iPhone 4", and can change anytime so relying on it >> for API access would be problematic. >> >> >> On Fri, Jun 17, 2016 at 1:51 AM, Philipp Kursawe >> wrote: >> >> > I wonder why such an important piece of information is not provided >> anymore >> > in the device plugin? >> > What was the reason to remove the property? >> > >> > The name of the device, especially when users can authorise/revoke API >> > access to apps on different devices, is an important variable to know. >> > >> > There is a plugin that brings back this functionality for Android, iOS >> and >> > for Windows it would be a one-liner only too. >> > https://github.com/becvert/cordova-plugin-device-name >> > >> > > --001a114b0d1856702c053580963d--