Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
From: stevengill <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-456-cordova-lib@git.apache.org>
In-Reply-To: <git-pr-456-cordova-lib@git.apache.org>
Subject: [GitHub] cordova-lib pull request #456: CB-11412 improve template implementation
Content-Type: text/plain
Message-Id: <20160614224144.B2E83DFDEF@git1-us-west.apache.org>
Date: Tue, 14 Jun 2016 22:41:44 +0000 (UTC)
archived-at: Tue, 14 Jun 2016 22:41:46 -0000

Github user stevengill commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/456#discussion_r67071311
  
    --- Diff: cordova-lib/spec-cordova/create.spec.js ---
    @@ -121,6 +122,36 @@ describe('create end-to-end', function() {
             // expect(configXml.name()).toEqual('TestBase');
         }
     
    +    function checkSubDir() {
    +        // Check if top level dirs exist.
    +        var dirs = ['hooks', 'platforms', 'plugins', 'www'];
    +        dirs.forEach(function(d) {
    +            expect(path.join(project, d)).toExist();
    +        });
    +        expect(path.join(project, 'hooks', 'README.md')).toExist();
    +        
    +        //index.js and template folder should not exist (inner files should be copied to the project folder)
    +        expect(path.join(project, 'index.js')).not.toExist();
    +        expect(path.join(project, 'template')).not.toExist();
    --- End diff --
    
    Is this assuming the template folder is named `template`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org