Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
From: vladimir-kotikov <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-7-cordova-paramedic@git.apache.org>
In-Reply-To: <git-pr-7-cordova-paramedic@git.apache.org>
Subject: [GitHub] cordova-paramedic pull request: CB-11332 Added Saucelabs support
Content-Type: text/plain
Message-Id: <20160601094138.5DF8BE0498@git1-us-west.apache.org>
Date: Wed,  1 Jun 2016 09:41:38 +0000 (UTC)
archived-at: Wed, 01 Jun 2016 09:41:45 -0000

Github user vladimir-kotikov commented on a diff in the pull request:

    https://github.com/apache/cordova-paramedic/pull/7#discussion_r65330792
  
    --- Diff: lib/paramedic.js ---
    @@ -296,5 +532,8 @@ exports.run = function(paramedicConfig) {
         runner.storedCWD = storedCWD;
     
         return runner.run()
    -    .timeout(paramedicConfig.getTimeout(), "This test seems to be blocked :: timeout exceeded. Exiting ...");
    +    .timeout(paramedicConfig.getTimeout(), 'This test seems to be blocked :: timeout exceeded. Exiting ...')
    +    .catch(function (error) {
    --- End diff --
    
    Should we catch errors here? They are being caught in `main.js already`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org