cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hollyschinsky <>
Subject [GitHub] cordova-plugin-file pull request #184: CB-11407 (ios): Added extern keyword ...
Date Thu, 09 Jun 2016 21:16:52 GMT
GitHub user hollyschinsky opened a pull request:

    CB-11407 (ios): Added extern keyword to constants to fix phonegap-webview-ios template

    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    ### Platforms affected
    ### What does this PR do?
    Fixes iOS embedded webview projects based on the [phonegap-webview-ios template](
due to the reasons explained in [CB-11407](
and template [issue 8] (
    ### What testing has been done on this change?
    This change has been tested locally with iOS embedded webview projects based on [this
    ### Checklist
    - [X] [ICLA]( has been signed and submitted to
    - [X] [Reported an issue]( in the JIRA
    - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [X] Added automated test coverage as appropriate for this change.

You can merge this pull request into a Git repository by running:

    $ git pull embed-webview-fix

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #184
commit 8d7191d8e6ab4187b58144e80299db0c8490afe2
Author: Holly Schinsky <>
Date:   2016-06-09T21:05:45Z

    CB-11407 ios: added extern keyword to constants to fix phonegap-webview-ios template issue.


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message