cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hoovercj <...@git.apache.org>
Subject [GitHub] cordova-windows pull request #179: CB-11516 windows: Preparing icons w/ targ...
Date Thu, 30 Jun 2016 07:35:43 GMT
GitHub user hoovercj opened a pull request:

    https://github.com/apache/cordova-windows/pull/179

    CB-11516 windows: Preparing icons w/ target fails

    Putting the following line in the config will will cause an error: "Source
    directory does not exist: Square44x44Logo_100.scale"
    <icon src="res/Windows/Square44x44Logo_100.png" target="SmallIcon"/>
    In prepare.js, `copyImages` calls `mapImageResources` but subdirectory
    information was lost. `copyMrtImage` in an earlier commit preserved this
    information (shown in the link below), but it was lost in a refactoring.
    https://github.com/apache/cordova-windows/blob/c1b80be51cdbd90160b6cb8162350bced8e1c44b/template/cordova/lib/prepare.js#L316
    This was missed by a defect in the `copyIcons` test in
    Prepare.Win10.spec.js:
    `readdirSync` was spied on to return an array of file paths when it
    actually only returns an array of the filenames. This caused the
    `copyIcons` spec to pass but the code failed when used.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/hoovercj/cordova-windows copyIconsWithTargets

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-windows/pull/179.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #179
    
----
commit 0f1be175ca6f6b37fa6f52b4d3ba9c7650a13281
Author: Cody Hoover <git@codyhoover.com>
Date:   2016-06-30T07:30:03Z

    CB-11516 windows: Preparing icons w/ target fails
    
    Putting the following line in the config will will cause an error: "Source
    directory does not exist: Square44x44Logo_100.scale"
    <icon src="res/Windows/Square44x44Logo_100.png" target="SmallIcon"/>
    In prepare.js, `copyImages` calls `mapImageResources` but subdirectory
    information was lost. `copyMrtImage` in an earlier commit preserved this
    information (shown in the link below), but it was lost in a refactoring.
    https://github.com/apache/cordova-windows/blob/c1b80be51cdbd90160b6cb8162350bced8e1c44b/template/cordova/lib/prepare.js#L316
    This was missed by a defect in the `copyIcons` test in
    Prepare.Win10.spec.js:
    `readdirSync` was spied on to return an array of file paths when it
    actually only returns an array of the filenames. This caused the
    `copyIcons` spec to pass but the code failed when used.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message