cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ben3005 <...@git.apache.org>
Subject [GitHub] cordova-plugin-file-transfer pull request #149: CB-11316 windows: Added cont...
Date Mon, 13 Jun 2016 11:00:02 GMT
GitHub user ben3005 opened a pull request:

    https://github.com/apache/cordova-plugin-file-transfer/pull/149

    CB-11316 windows: Added content-type for files

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    Windows
    
    ### What does this PR do?
    Adds Content-Type header for files in the multi-part upload
    
    ### What testing has been done on this change?
    ran `npm test`
    
    Tested plugin before with this result:
    ![aapche-before](https://cloud.githubusercontent.com/assets/2751508/16005224/061072c8-315e-11e6-9c7b-3a26c4e7129f.png)
    
    Tested forked change with the following result:
    ![aapche-after](https://cloud.githubusercontent.com/assets/2751508/16005241/18bfc39c-315e-11e6-9e4b-8fedecdc5443.png)
    
    
    ### Checklist
    - [x] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and submitted to
secretary@apache.org.
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.
    
    - added Content-Type header for each file in the multipart upload

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ben3005/cordova-plugin-file-transfer master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-file-transfer/pull/149.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #149
    
----
commit b639542b57f66df1d78f589f7608ee6f2039872b
Author: Ben Marshall <ben3005@users.noreply.github.com>
Date:   2016-06-07T12:56:57Z

    CB-11316 windows: Added content-type for files
    
    - added Content-Type header for each file in the multipart upload

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message