cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From EddyVerbruggen <...@git.apache.org>
Subject [GitHub] cordova-plugin-contacts pull request #129: CB-11455: (ios) Add mandatory iOS...
Date Mon, 20 Jun 2016 17:22:08 GMT
GitHub user EddyVerbruggen opened a pull request:

    https://github.com/apache/cordova-plugin-contacts/pull/129

    CB-11455: (ios) Add mandatory iOS 10 privacy description

    ### Platforms affected
    iOS
    
    ### What does this PR do?
    Adds mandatory iOS 10 privacy description; since iOS 6 Apple provided a way to show the
user why a certain permission is required. In iOS 10 this becomes mandatory, so any app not
specifying the key will crash at runtime when a permissions is requested.
    
    This plugin requests the Contacts permission, so at the very least we need to add `NSContactsUsageDescription`
to the `plist`.
    
    Note that this is the same approach as the Geolocation plugin has taken a while ago.
    
    ### What testing has been done on this change?
    Deployed this plugin in an app on iOS 10 (developer preview) which crashed as expect upon
permission request. After adding the `plist` key the crash disappeared and since the value
of the description is empty the UI is the same as before. It is recommended by Apple though
to actually provide a description. But at least this is way better than a crash :)
    
    ### Checklist
    - [x] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and submitted to
secretary@apache.org.
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database: https://issues.apache.org/jira/browse/CB-11455
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/EddyVerbruggen/cordova-plugin-contacts master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-contacts/pull/129.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #129
    
----
commit 6b7bccb7c2f81cd91e26fa96fc4b7acc3c32feac
Author: Eddy Verbruggen <eddyverbruggen@users.noreply.github.com>
Date:   2016-06-20T17:12:57Z

    Added mandatory iOS 10 privacy description
    
    Since iOS 6 Apple provided a way to show the user why a certain permission is required.
In iOS 10 this becomes mandatory, so any app not specifying the key will crash at runtime
when a permissions is requested.
    
    This plugin relies requests the Contacts permission, so at the very least we need to add
`NSContactsUsageDescription` to the `plist`.
    
    Note that this is the same approach as the Geolocation plugin has taken a while ago.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message