cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mccraigmccraig <...@git.apache.org>
Subject [GitHub] cordova-plugin-wkwebview-engine pull request #11: CB-9888: (iOS) check & rel...
Date Mon, 13 Jun 2016 22:02:02 GMT
GitHub user mccraigmccraig opened a pull request:

    https://github.com/apache/cordova-plugin-wkwebview-engine/pull/11

    CB-9888: (iOS) check & reload WKWebView

    PR as discussed on JIRA @shazron 
    
    ### Platforms affected
    
    iOS 9
    
    ### What does this PR do?
    
    Checks whether the WKWebView content process has died when the app enters
    the foreground. If it has, then reloads the WKWebView
    
    ### What testing has been done on this change?
    
    Tested on iOS9.3 emulator and iPhone 6 / 9.3.1
    
    ### Checklist
    - [x] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and submitted to
secretary@apache.org.
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [x] Added automated test coverage as appropriate for this change.
    
    When an app is entering the foreground,
    the WKWebView content process sometimes dies without
    calling the webViewContentProcessDidTerminate delegate function.
    
    This PR checks whether the content process has died, by
    examining the title property of the WKWebView, which is nil
    when the process has died.
    
    If the process has died the WKWebView is reloaded,
    which avoids the White Screen Of Death problem described
    in CB-9888.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/employeerepublic/cordova-plugin-wkwebview-engine 1.0.x-reload-on-resume-CB9888-3

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-wkwebview-engine/pull/11.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #11
    
----
commit 0966cd31b40ca1dd2f16f0d98f02919b8eb47e69
Author: mccraig mccraig of the clan mccraig <mccraigmccraig@gmail.com>
Date:   2016-06-13T21:41:05Z

    CB-9888: (iOS) check & reload WKWebView
    
    When an app is entering the foreground,
    the WKWebView content process sometimes dies without
    calling the webViewContentProcessDidTerminate delegate function.
    
    This PR checks whether the content process has died, by
    examining the title property of the WKWebView, which is nil
    when the process has died.
    
    If the process has died the WKWebView is reloaded,
    which avoids the White Screen Of Death problem described
    in CB-9888.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message